Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not init git config on help and version cmds #209

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

pwinckles
Copy link
Contributor

This PR resolves #206 and #90.

The root cause is that git commands were being run for all subcommands, instead of just the ones that needed them. This PR changes when the git config is resolved so that the problematic commands are not run for version and help.

Additionally, it slightly improves the error message when you invoke a subcommand that does need to be run from within a git repo. Previously, it would produce a cryptic exit status 128 response.

@Envek Envek merged commit ad086ac into evilmartians:master Jun 10, 2021
Envek pushed a commit that referenced this pull request Jun 10, 2021
Allow to run `lefthook version` and `lefthook help` commands outside of a git repository.
@Envek
Copy link
Member

Envek commented Oct 2, 2021

Released in 0.7.7

Envek added a commit that referenced this pull request Jun 6, 2022
* origin/0-7-stable:
  0.7.7: Fix arguments passing and various NPM-related fixes
  Fix incorrect npx command in git hook script template (#236)
  Update project URLs in NPM package.json (#235)
  Pass all arguments to downstream hooks (#231)
  Allows lefthook to work when node_modules is not in root folder for npx (#224)
  Do not initialize git config on `help` and `version` commands (#209)
  node: fix postinstall: process.cwd is a function and should be called
mrexox added a commit that referenced this pull request Jun 9, 2022
* master:
  Account for GOAMD64 suffix in directory names in NPM and GEM packages [ci skip]
  Include version into RPM/DEB packages on release [ci skip]
  0.8.0: Skip hooks in merge/rebase, hide summary, NPM installer package
  Split NPM package to two: bundled and installer (#273)
  Include archived binaries in the releases (#189)
  docs: s/agrs/args (#265) [ci skip]
  chore(lint): Fix golangci-lint complains
  docs(usage): Add commitlint example in full_guide (#201)
  Fix unreachable conditional in hook template (#242)
  fix(hook.tmpl): adds cpu arch and os arch to `lefthook`'s filepath (#260)
  Replace deprecated `File.exists?` with `exist?` for Ruby wrapper (#263)
  Fix typo in docs/full_guide.md (#256)
  0.7.7: Fix arguments passing and various NPM-related fixes
  Fix incorrect npx command in git hook script template (#236)
  Update project URLs in NPM package.json (#235)
  Pass all arguments to downstream hooks (#231)
  Allows lefthook to work when node_modules is not in root folder for npx (#224)
  Do not initialize git config on `help` and `version` commands (#209)
  node: fix postinstall: process.cwd is a function and should be called

Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subcommands return status 128
3 participants